> From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: Thursday, April 11, 2013 11:39 AM > > On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: > > diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt b/Documentation/devicetree/bindings/staging/dwc2.txt > > index 3649c88..05d9c08 100644 > > --- a/Documentation/devicetree/bindings/staging/dwc2.txt > > +++ b/Documentation/devicetree/bindings/staging/dwc2.txt > > @@ -5,6 +5,39 @@ Required properties: > > - compatible : "snps,dwc2" > > - reg : Should contain 1 register range (address and length) > > - interrupts : Should contain 1 interrupt > > +Optional properties: > > + - dma-enable > > + - otg-cap > > + - otg-ver > > + - dma-enable > > + - dma-desc-enable > > + - speed > > + - enable-dynamic-fifo > > + - en-multiple-tx-fifo > > + - host-rx-fifo-size > > + - host-nperio-tx-fifo-size > > + - host-perio-tx-fifo-size > > + - max-transfer-size > > + - max-packet-count > > + - host-channels > > + - phy-type > > + - phy-utmi-width > > + - phy-ulpi-ddr > > + - phy-ulpi-ext-vbus > > + - i2c-enable > > + - ulpi-fs-ls > > + - host-support-fs-ls-low-power > > + - nhost-ls-low-power-phy-clk > > + - ts-dline > > + - reload-ctl > > + - ahb-single > > are you 110% sure you want all of these parameters ? You will have to > support them forever once it gets accepted in mainline kernel. After DT > is accepted, it's really, really hard to change. Sadly, a lot of these are actually required. But Matthijs, I believe several of these (otg-cap, otg-ver, ts-dline?) are only for peripheral mode, so they could be removed for now, and only brought back if needed when peripheral mode is implemented. And I think a couple of others (reload-ctl, ?) are not actually used in the driver, so they could be removed. And I agree with Felipe that 'speed' is only for debugging, so it doesn't belong in dt. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
