Hi Felipe, On Thu, Apr 11, 2013 at 09:39:26PM +0300, Felipe Balbi wrote: > On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: [devicetree params] > > + - ahb-single > > are you 110% sure you want all of these parameters ? You will have to > support them forever once it gets accepted in mainline kernel. After DT > is accepted, it's really, really hard to change. I had in mind to revisit this list when the drivers leaves staging, just like the debug prints in the code are intended to be stripped later on. For now, I just added whatever params are available (which is what used to be module params before). Perhaps it is ok like this with a notice about this in the bindings documentation? > > > @@ -12,4 +45,7 @@ Example: > > compatible = "ralink,rt3050-otg, snps,dwc2"; > > reg = <0x101c0000 40000>; > > interrupts = <18>; > > + > > + # Force slave mode, even when dma is advertised to work > > + dma-enable = <0>; > > looks like a test feature. Yeah, I guess it is. > > > diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c > > index e65fa0d..9e05865 100644 > > --- a/drivers/staging/dwc2/platform.c > > +++ b/drivers/staging/dwc2/platform.c > > @@ -40,6 +40,8 @@ > > #include <linux/device.h> > > #include <linux/dma-mapping.h> > > #include <linux/platform_device.h> > > +#include <linux/of.h> > > +#include <asm/byteorder.h> > > can you use the generic header instead ? Which one would that be? asm/byteorder.h seems to be used by most drivers? Gr. Matthijs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
