On Thu, 2013-04-11 at 06:45 -0700, Greg KH wrote: > I only have one very minor question about the code: > > > +++ b/drivers/usb/serial/wishbone-serial.c > > @@ -0,0 +1,95 @@ > > +/* > > + * USB Wishbone-Serial adapter driver > > + * > > + * Copyright (C) 2013 Wesley W. Terpstra <w.terpstra@xxxxxx> > > + * Copyright (C) 2013 GSI Helmholtz Centre for Heavy Ion Research GmbH > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License > > + * as published by the Free Software Foundation; either version 2 > > + * of the License, or (at your option) any later version. > > + */ > > Do you really mean "or any later version" for the license of this > driver? I ask as the kernel itself is GPLv2-only. It's fine if you > want this to be GPLv2+, I just have to ask. Yes, I know the kernel is v2. Which is a shame because the FSF made the v3 licence which some people would prefer. If in the distant future, the kernel were to slowly be relicenced as v2+ or v3, I don't want to contribute to the migration problem. A question for you in turn: why were usb_serial_[de]register removed? The new usb_serial_deregister_drivers isn't available in older kernels. So drivers cannot support (without ifdefs) both old and new kernels -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html