On Thu, Apr 11, 2013 at 03:08:20PM +0200, Wesley W. Terpstra wrote: > Wishbone is an open hardware SoC bus commonly used in FPGA > designs. Bus access can be serialized using the Etherbone > protocol <http://www.ohwr.org/projects/etherbone-core>. > > This driver is intended to be used with devices which attach > their internal Wishbone bus to a USB serial interface using > the Etherbone protocol. A userspace library is required to > speak the protocol made available by this driver as ttyUSBx. > > Signed-off-by: Wesley W. Terpstra <w.terpstra@xxxxxx> This looks great, thanks. I only have one very minor question about the code: > +++ b/drivers/usb/serial/wishbone-serial.c > @@ -0,0 +1,95 @@ > +/* > + * USB Wishbone-Serial adapter driver > + * > + * Copyright (C) 2013 Wesley W. Terpstra <w.terpstra@xxxxxx> > + * Copyright (C) 2013 GSI Helmholtz Centre for Heavy Ion Research GmbH > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2 > + * of the License, or (at your option) any later version. > + */ Do you really mean "or any later version" for the license of this driver? I ask as the kernel itself is GPLv2-only. It's fine if you want this to be GPLv2+, I just have to ask. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
