[RFC PATCH 31/41] staging: dwc2: don't pass IRQ_LEVEL to devm_request_irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It seems this flag is intended to pass to irq_set_status_flags, not
request_irq, and is not available on all architectures. Its value
corresponds to IRQF_PROBE_SHARED, which shouldn't be needed for this
driver, so removing this flag should be safe.

Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
---
 drivers/staging/dwc2/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

See include/linux/irq.h:

 * Bits which can be modified via irq_set/clear/modify_status_flags()
[...]
        IRQ_LEVEL               = (1 <<  8),

and include/linux/interrupt.h:

#define IRQF_PROBE_SHARED       0x00000100

diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
index 63b7c1a..928298a 100644
--- a/drivers/staging/dwc2/pci.c
+++ b/drivers/staging/dwc2/pci.c
@@ -157,7 +157,7 @@ static int dwc2_driver_probe(struct pci_dev *dev,
 
 	dev_dbg(&dev->dev, "registering common handler for irq%d\n", dev->irq);
 	retval = devm_request_irq(&dev->dev, dev->irq, dwc2_handle_common_intr,
-				  IRQF_SHARED | IRQ_LEVEL, dev_name(&dev->dev),
+				  IRQF_SHARED, dev_name(&dev->dev),
 				  hsotg);
 	if (retval)
 		dwc2_hcd_remove(hsotg);
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux