Re: [PATCH v3] usb: phy: add R-Car USB phy driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergei

Thank you for pointing it

> >> 0xAAAA0000  ===========
> >>                 EHCI
> >>              ----------
> >> 0xAAAA0094     PHY
> >> 0xAAAA009C     PHY
> >>              ----------
> >>                 EHCI
> >> 0xAAAA0400  ==========
> >> ...
> >> 0xAAAA0800  ----------
> >>                 PHY
> >> 0xAAAA0900  ----------
> >>
> >> This driver couldn't probe if it used "request_mem_region()"
> > Fair enough. I must say, though. That's a peculiar register mapping ;-)
> >
> 
>     Not peculiar enough to not be able to overcome it. Those registers 
> at 0xAAAA009[4C]
> are not really PHY related, they control EHCI internal buffering. They 
> probably shouldn't
> have been a part of this driver even...

I'm not sure what is the best solution.
But current rcar_usb_phy is expecting above (strange) mapping,
and initialize method is came from datasheet

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux