Hi Abraham
Thank you for checking patch
> > +config USB_RCAR_PHY
> > + tristate "Renesas R-Car USB phy support"
> > + depends on (USB || USB_GADGET) && ARCH_R8A7779
> > + help
> > + Say Y here to add support for the Renesas R-Car USB phy driver.
>
> Just out of curiosity, which USB contoller will/is using this PHY?
EHCI/OHCI.
Now, I'm using ohci/ehci-platform.c
> > + reg0 = ioremap_nocache(res0->start, resource_size(res0));
> > + reg1 = ioremap_nocache(res1->start, resource_size(res1));
>
> Instead use devm_ioremap_nocache?
will do in v2 patch
> > + /* (1) USB-PHY standby release */
> > + iowrite32(0x00000001, (reg0 + USBPCTRL1));
>
> Can we have some macros to define the above constant (and for the
> constants used below)?
will do in v2 patch
> > +
> > + /* (2) start USB-PHY internal PLL */
> > + iowrite32(0x00000003, (reg0 + USBPCTRL1));
>
> No power management stuff added?? Dont we need to stop this PLL during suspend??
(snip)
> I see you are doing one time initialization of the phy during probe.
> But I think this phy will be pointless without the usb controller.
> Instead how about using the library functions like
> usb_add_phy/usb_get_phy/usb_phy_init?
I'm not sure detail, but this usb_xxx_phy() is under otg.
Our system don't support it, but is it normal ?
Now, I'm using ehci/ohci-platform.
When I support this usb_xxx_phy(), do I need to customize these drivers ?
And, this is extra stuff, but I have 1 question.
it is ${LINUX}/driver/usb/Makefile's order.
obj-(xxx) += host/
...
obj-(xxx) += phy/
This means that usb phy driver probe function is called
after host driver probe function().
Now, I'm using a technique which delays usb host driver registration,
but why phy driver is called after host driver ?
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
