On Thu, Feb 21, 2013 at 07:57:14PM +0000, Paul Zimmerman wrote: > > -----Original Message----- > > From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Thursday, February 21, 2013 11:43 AM > > > > On Thu, Feb 21, 2013 at 07:33:45PM +0000, Paul Zimmerman wrote: > > > > > > I can pare the user-visible module parameters down to 6, that would > > > give us most of what we need for testing purposes. The remainder I > > > can leave in the parameter struct, so they can be tweaked at build time, > > > but not add module_param() calls for them. How does that sound? > > > > Not good, you shouldn't have any module parameters if at all possible. > > > > As you are saying you only need them for "testing", they why not put > > them in dynamic files, like debugfs, instead? > > Hi Greg, > > These parameters need to be set at driver initialization time. Why, what do they control? > I don't think debugfs will work for that, since the debugfs files > won't exist before the driver is loaded. Am I wrong? No, that is correct, but you could wait to initialize your device until later if needed. Or disconnect it and reconnect it logically if the debugfs files are written to. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
