Hi, On Tue, Feb 19, 2013 at 06:50:03PM -0800, Paul Zimmerman wrote: > Here is v4 of the DWC2 patch set. I made most of the changes you asked > for, except for the following: > - I did not convert to a threaded IRQ handler. I would like to postpone > that for now. without any reasoning ? > - I did not use an asychronous function call during driver initialization > in dwc2_hcd_start(), because that function is also called during runtime > if a role switch occurs. fair enough. > - I did not convert to devm_request_and_ioremap() in the probe function, > because that requires a struct resource, which you don't have in a PCI > driver. Perhaps I'm missing something. look at line 287 on include/linux/pci.h > - I did not move the devm_request_irq() call into the dwc2 module. IMHO > it's cleaner to have that in the bus glue module wih the other devm* > calls. if you say so... it will still hurt you whenever you get more than 3 users though, you'll see that a bunch of code will be duplicated on every bus glue. > - I removed a few unneeded module parameters, but left the rest for now. > I discovered that some of the parameters need to be set to non- > hardware-default values, or else the driver doesn't work correctly. isn't that something which is wrong with your FPGA model ? IIRC you can change register default values via coreConsultant. I'll review the actual patches later today. cheers -- balbi
Attachment:
signature.asc
Description: Digital signature
