RE: [PATCH v4 0/5] DWC2 DesignWare HS OTG driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, February 21, 2013 11:43 AM
> 
> On Thu, Feb 21, 2013 at 07:33:45PM +0000, Paul Zimmerman wrote:
> >
> > I can pare the user-visible module parameters down to 6, that would
> > give us most of what we need for testing purposes. The remainder I
> > can leave in the parameter struct, so they can be tweaked at build time,
> > but not add module_param() calls for them. How does that sound?
> 
> Not good, you shouldn't have any module parameters if at all possible.
> 
> As you are saying you only need them for "testing", they why not put
> them in dynamic files, like debugfs, instead?

Hi Greg,

These parameters need to be set at driver initialization time. I don't
think debugfs will work for that, since the debugfs files won't exist
before the driver is loaded. Am I wrong?

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux