Dear Greg: OK, I have fixed up and resend the patches based on linux-3.8-rc4 today. Email subjects: 1. [PATCH 1/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices 2. [PATCH 2/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices Please apply them, thank you very much. Best Regards, Franko Fang > -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Tuesday, January 22, 2013 1:12 AM > To: Fangxiaozhi (Franko) > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Xueguiying (Zihan); > Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@xxxxxx; > mdharm-usb@xxxxxxxxxxxxxxxxxx; sebastian@xxxxxxxxxxxxx > Subject: Re: USB: storage: optimize the matching rules and support new switch > command for Huawei USB storage devices > > On Mon, Jan 21, 2013 at 03:37:15AM +0000, Fangxiaozhi (Franko) wrote: > > Dear Greg: > > > > > I get the following errors: > > > > > > drivers/usb/storage/unusual_devs.h:1530:1: error: implicit > > > declaration of function ‘UNUSUAL_VENDOR_INTF’ > > > [-Werror=implicit-function-declaration] > > > drivers/usb/storage/unusual_devs.h:1534:3: warning: missing braces > > > around initializer [-Wmissing-braces] > > > drivers/usb/storage/unusual_devs.h:1534:3: warning: (near > > > initialization for > > > ‘us_unusual_dev_list[186]’) [-Wmissing-braces] > > > drivers/usb/storage/unusual_devs.h:1534:3: error: initializer > > > element is not constant > > > drivers/usb/storage/unusual_devs.h:1534:3: error: (near > > > initialization for > > > ‘us_unusual_dev_list[186].vendorName’) > > > drivers/usb/storage/unusual_devs.h:1537:1: warning: braces around > > > scalar initializer [enabled by default] > > > > > > And it goes on and on... > > ----------The macro define, please see another patch: > > [PATCH 1/1]linux-usb:Define a new macro for USB storage match rules > > http://www.spinics.net/lists/linux-usb/msg76629.html > > Please resend it, I do not have this patch anymore in my queue. > Remember, I asked you to resend everything that was needed, with the proper > ordering. > > Please resend all patches, properly fixed up, that you wish to see applied. > > thanks, > > greg k-h ��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥