Dear Greg: > -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Saturday, January 19, 2013 7:44 AM > To: Fangxiaozhi (Franko) > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Xueguiying (Zihan); > Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@xxxxxx; > mdharm-usb@xxxxxxxxxxxxxxxxxx; sebastian@xxxxxxxxxxxxx > Subject: Re: USB: storage: optimize the matching rules and support new switch > command for Huawei USB storage devices > > On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote: > > > > From: fangxiaozhi <huananhu@xxxxxxxxxx> > > > > 1. Optimize the matching rules with new macro for Huawei USB storage > > devices, to avoid to load USB storage driver for the modem interface > > with Huawei devices. > > 2. Add to support new switch command for new Huawei USB dongles. > > > > Signed-off-by: fangxiaozhi <huananhu@xxxxxxxxxx> > > This patch breaks the build, did you test it out? > > I get the following errors: > > drivers/usb/storage/unusual_devs.h:1530:1: error: implicit declaration of > function ‘UNUSUAL_VENDOR_INTF’ [-Werror=implicit-function-declaration] > drivers/usb/storage/unusual_devs.h:1534:3: warning: missing braces around > initializer [-Wmissing-braces] > drivers/usb/storage/unusual_devs.h:1534:3: warning: (near initialization for > ‘us_unusual_dev_list[186]’) [-Wmissing-braces] > drivers/usb/storage/unusual_devs.h:1534:3: error: initializer element is not > constant > drivers/usb/storage/unusual_devs.h:1534:3: error: (near initialization for > ‘us_unusual_dev_list[186].vendorName’) > drivers/usb/storage/unusual_devs.h:1537:1: warning: braces around scalar > initializer [enabled by default] > > And it goes on and on... ----------The macro define, please see another patch: [PATCH 1/1]linux-usb:Define a new macro for USB storage match rules http://www.spinics.net/lists/linux-usb/msg76629.html > Care to fix this up and resend it? > > thanks, > > greg k-h Best Regards, Franko Fang ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
