gregkh@xxxxxxxxxxxxxxxxxxx, balbi@xxxxxx, stern@xxxxxxxxxxxxxxxxxxx Cc: linux-usb@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, festevam@xxxxxxxxx, marex@xxxxxxx, matt@xxxxxxxxxxxxxx, shawn.guo@xxxxxxxxxx, kernel@xxxxxxxxxxxxxx, mkl@xxxxxxxxxxxxxx, m.grzeschik@xxxxxxxxxxxxxx, maxime.ripard@xxxxxxxxxxxxxxxxxx Bcc: Subject: Re: [RESEND PATCH v5 0/7] Add fully tested id switch and vbus connect detect support for Chipidea Reply-To: In-Reply-To: <1358733418-17969-1-git-send-email-peter.chen@xxxxxxxxxxxxx> Hi Alex, Would you help to review recently chipidea patchsets, including mine and Michael Grzeschik/Marc Kleine-Budde's. Alan may delete CONFIG_USB_SUSPEND at next release (v3.9?), in that case, the imx chipidea driver will be out of work. So, I have worked on power management for chipidea recently, this work is based on the patchsets I mentioned above. Thanks On Mon, Jan 21, 2013 at 09:56:51AM +0800, Peter Chen wrote: > Only one typo suggestion from Marek Vasut (change "d" to "D") is added. > At this v5 version. > Anyone who have tested this patchset, please give a tested-by, thanks. > > This patchset adds fully tested otg id switch function and > vbus connect/disconnect detection for chipidea driver. > The mainly design of id/vbus handling follows msm otg driver. > I hope the msm usb maintainer can have a look of this patchset, > and give some comments, and move the whole msm usb driver to > chipidea framework if possible in the future. > > This patchset is fully tested at i.mx6Q saberlite board. > > There is github repo for my chipdiea work: > https://github.com/hzpeterchen/linux-usb.git > branch: master > > Peter Chen (7): > Revert "USB: chipidea: add vbus detect for udc" > usb: chipidea: add otg file > usb: chipidea: add otg id switch and vbus connect/disconnect detect > usb: chipidea: consolidate ci_role_driver's API for both roles > usb: chipidea: udc: add pullup/pulldown dp at hw_device_state > usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS > usb: chipidea: imx: add internal vbus regulator control > > drivers/usb/chipidea/Makefile | 2 +- > drivers/usb/chipidea/bits.h | 10 ++ > drivers/usb/chipidea/ci.h | 30 ++++++- > drivers/usb/chipidea/ci13xxx_imx.c | 81 +++++++++++++---- > drivers/usb/chipidea/ci13xxx_msm.c | 1 - > drivers/usb/chipidea/core.c | 178 +++++++++++++++++++++++++++++++----- > drivers/usb/chipidea/host.c | 2 + > drivers/usb/chipidea/otg.c | 68 ++++++++++++++ > drivers/usb/chipidea/otg.h | 9 ++ > drivers/usb/chipidea/udc.c | 101 ++++++++++----------- > include/linux/usb/chipidea.h | 1 - > 11 files changed, 382 insertions(+), 101 deletions(-) > create mode 100644 drivers/usb/chipidea/otg.c > create mode 100644 drivers/usb/chipidea/otg.h > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html