Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote:
> 
> From: fangxiaozhi <huananhu@xxxxxxxxxx>
> 
> 1. Optimize the matching rules with new macro for Huawei USB storage
>    devices, to avoid to load USB storage driver for the modem interface
>    with Huawei devices.
> 2. Add to support new switch command for new Huawei USB dongles.
> 
> Signed-off-by: fangxiaozhi <huananhu@xxxxxxxxxx>

This patch breaks the build, did you test it out?

I get the following errors:

drivers/usb/storage/unusual_devs.h:1530:1: error: implicit declaration of function ‘UNUSUAL_VENDOR_INTF’ [-Werror=implicit-function-declaration]
drivers/usb/storage/unusual_devs.h:1534:3: warning: missing braces around initializer [-Wmissing-braces]
drivers/usb/storage/unusual_devs.h:1534:3: warning: (near initialization for ‘us_unusual_dev_list[186]’) [-Wmissing-braces]
drivers/usb/storage/unusual_devs.h:1534:3: error: initializer element is not constant
drivers/usb/storage/unusual_devs.h:1534:3: error: (near initialization for ‘us_unusual_dev_list[186].vendorName’)
drivers/usb/storage/unusual_devs.h:1537:1: warning: braces around scalar initializer [enabled by default]

And it goes on and on...

Care to fix this up and resend it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux