Re: [PATCH] drivers/usb/host/ohci* : set urb->hcpriv = NULL immediately, after free it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



于 2012年12月18日 23:17, Alan Stern 写道:
>>  static void urb_free_priv (struct ohci_hcd *hc, urb_priv_t *urb_priv)
>> >  {
>> > -	int		last = urb_priv->length - 1;
>> > +	int		last;
>> >  
>> > +	if (!urb_priv)
>> > +		return;
>> > +
>> > +	last = urb_priv->length - 1;
> Please don't do this.  If urb_priv is NULL, that's a bug.  We want it 
> to cause a visible error, not silently fail.
> 

  good idea !  (for private use, it is a good idea)


  I'll send patch v2


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux