Re: doubt about usb_cancel_queued_reset()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 23, 2012 at 10:39 PM, Oliver Neukum <oneukum@xxxxxxx> wrote:
> Hi,
>
> in usb_unbind_interface() we call usb_cancel_queued_reset() before
> restoring altsetting 0. This seems wrong to me. If a driver found it
> necessary to reset a device we cannot simply ignore that. I'd say
> that we should wait for the work to finish, not cancel it.
> What do you say?

Part of doing so may be related with below:

           The lifecycle of the work_struct is tied to the usb_interface.

On the other side, it is still reasonable to cancel the reset because
the interface driver which triggers the reset is to be unbound.


Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux