Re: [PATCH 06/29] usb: host: ehci-mv: fix clk APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 21 Nov 2012, Chao Xie wrote:

> From: Chao Xie <chao.xie@xxxxxxxxxxx>
> 
> Signed-off-by: Chao Xie <xiechao.mail@xxxxxxxxx>

I don't like patches with no patch description.  You should write 
something here, explaining why the change is needed.  What's wrong with 
the clk APIs?

The same hold for your other patches, except perhaps the trivial one 
that removes an unused local variable definition.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux