Hi, On Wed, Nov 21, 2012 at 12:05:12PM +0200, Roger Quadros wrote: > Hi Tony, > > On 11/21/2012 01:13 AM, Tony Lindgren wrote: > > Hi Roger, > > > > * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [121119 15:24]: > >> Roger Quadros <rogerq@xxxxxx> writes: > >> > >>> Kevin, > >>> > >>> On 11/16/2012 10:08 PM, Kevin Hilman wrote: > >>>> Roger Quadros <rogerq@xxxxxx> writes: > >>>> > >>>>> Hi, > >>>>> > >>>>> This patchset addresses the following > >>>>> > >>>>> - Avoid addressing clocks one by one by name and use a for loop + bunch > >>>>> of cleanups. > >>>>> - Get number of channels/ports dynamically either from revision register > >>>>> or from platform data. Avoids getting clocks that are not present. > >>>>> - Add OMAP5 and HSIC mode (Not tested) > >>>>> - Save power on Panda when EHCI driver is not loaded. > >>>>> > >>>> > >>>> Seeing the clock changes/cleanups, I gave this a spin on OMAP3 > >>>> (3530/Beagle, 3530/Overo, 3730/Beagle-xM, 3730/OveroSTORM) to see if it > >>>> fixed up the problem where CORE does not hit retention in idle when USB > >>>> host is enabled, even with no devices attached. > >>>> > >>>> Unfortunately, it didn't help. :( > >>> > >>> oh that's bad. But this series wasn't meant to fix that ;). > >> > >> Oh, sorry. Yeah, I didn't mean this as a nak. Just an opportunity to > >> complain to the maintainers that a long-standing issue needs to be > >> addressed. > > > > It seems that drivers/mfd/omap-usb-host.c is one of the last users > > of cpu_is_omap macros blocking enabling ARM multiplatform support for > > omap2+. > > > > Please fix that ASAP as early as possible in this patch series to > > remove the dependencies between core omap code development and driver > > development. > > > > Basically you need to remove #include <plat/cpu.h> and pass the > > revision information in platform data (and device tree compatible > > flag when that is supported). > > > > Okay I'll send a patch to fix that ASAP. > > Felipe, any comments on the patches in this series? I'm waiting for Keshava's comments since he's the one who has been dealing with omap usb host the most. I can look into this series too shortly. -- balbi
Attachment:
signature.asc
Description: Digital signature
