On Thu, Nov 01, 2012 at 02:46:56PM +0100, Michal Nazarewicz wrote: > > ie. f_mass_storage.c is the 5th biggest file in drivers/usb/gadget, so > if anything, I would rather split it further into pieces than merge it > with storage_common.c adding another 700 lines and producing the biggest > file in drivers/usb/gadget (or something close to it). This are just 800 lines or say 30% of total. It includes static descriptors which are used and other stuff which belongs and is local to the function. Please merge these two files into f_mass.*. If you feel like splitting code and get the file smaller then I suggest to split by functionality (i.e. move the command parsing stuff out). I tried this with TCM: I had one file the gadget / descriptor thingy, one for BOT and one file for UAS. At the time the code was merge upstream I figured out that the target maintainer merged everything in one file… Unfortunately the tcm gadget did not make it in your top10. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
