> On Wed, Oct 31, 2012 at 09:32:38PM +0100, Michal Nazarewicz wrote:
>> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>>
>> Since function-line macros are to be avoided, this commit replaces
>> the fsg_lun_is_open() macro with a static inline function.
>>
>> While at it, this commit also adds “inline” modifier to the
>> fsg_lun_from_dev() function.
>>
>> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
On Thu, Nov 01 2012, Felipe Balbi wrote:
> looks like we can merge storage_common into f_mass_storage too since now
> it's the only user ?
I was thinking about that, but consider the following:
$ wc -l *.[ch] |grep -v total |sort -nr |head -n10 |cat -n
1 3721 s3c-hsotg.c
2 3477 lpc32xx_udc.c
3 3409 amd5536udc.c
4 3297 pch_udc.c
5 3098 f_mass_storage.c
6 3076 omap_udc.c
7 2896 net2280.c
8 2797 fsl_udc_core.c
9 2780 dummy_hcd.c
10 2750 fsl_qe_udc.c
ie. f_mass_storage.c is the 5th biggest file in drivers/usb/gadget, so
if anything, I would rather split it further into pieces than merge it
with storage_common.c adding another 700 lines and producing the biggest
file in drivers/usb/gadget (or something close to it).
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--Attachment:
pgpD5htn9KFUa.pgp
Description: PGP signature
