On Wednesday, September 26, 2012 09:57:57 AM Joe Perches wrote:
> On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote:
> > The PHY framework provides a set of API's for the PHY drivers to
> > create/destroy a PHY and API's
>
> Just some trivial notes.
>
> > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
>
> []
>
> > @@ -0,0 +1,445 @@
>
> []
>
> > +static void devm_phy_release(struct device *dev, void *res)
> > +{
> > + struct phy *phy = *(struct phy **)res;
>
> That's a bit twisted isn't it?
> Perhaps
> struct phy *phy = res;
No, because you really need to dereference ptr, not simply cast.
...
> > +
> > + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL);
>
> Is this the right size?
>
> Because ptr is **, perhaps sizeof(struct phy) is clearer.
But incorrect.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
