On Sat, 22 Sep 2012, Ming Lei wrote: > > So your patch does not fix the problem, although it does make the > > problem less likely to occur. > > Exactly. > > Considered that runtime suspend may be often happened on hub devices, > and status endpoint interval is about 256ms which should be a bit > longer, adding the check in hub_suspend might make sense. > > In theory, device connection change may happen between the check > and enabling remote-wakeup capability, but the period is very short. > > Also, I don't have a strong desire for the patch if you object to it, :-) Can you check the port statuses only for buggy hubs? Or at least, only for those with Vendor ID = 0x05e3 (Genesys Logic)? Maybe introduce a bitflag for this quirk in the usb_hub structure. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html