Re: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 19, 2012 at 09:32:49AM +0800, Richard Zhao wrote:
> On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> > Dear Richard Zhao,
> > 
> > You know, commit message would be nice to have.
> Yes, but for this one, the title shows obviously what it changed,
> doesn't it?

Alex has the the final word, but I'm also very picky about commit
messages. IMHO, all patches should have commit message, even if it
sounds obvious.

For example, you could let us know the reasoning behind converting to
devm_request_irq().

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux