Re: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote:
> Dear Richard Zhao,
> 
> You know, commit message would be nice to have.
Yes, but for this one, the title shows obviously what it changed,
doesn't it?

Thanks
Richard
> 
> > Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx>
> 
> Otherwise
> 
> Reviewed-by: Marek Vasut <marex@xxxxxxx>
> 
> > ---
> >  drivers/usb/chipidea/core.c |    5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 307651b..0942b9b 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct
> > platform_device *pdev) }
> > 
> >  	platform_set_drvdata(pdev, ci);
> > -	ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name,
> > -			  ci);
> > +	ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED,
> > +				ci->platdata->name, ci);
> >  	if (ret)
> >  		goto stop;
> > 
> > @@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct
> > platform_device *pdev) flush_workqueue(ci->wq);
> >  	destroy_workqueue(ci->wq);
> >  	device_remove_file(ci->dev, &dev_attr_role);
> > -	free_irq(ci->irq, ci);
> >  	ci_role_stop(ci);
> > 
> >  	return 0;
> 
> Best regards,
> Marek Vasut
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux