On 2012年08月22日 23:18, Alan Stern wrote: > On Wed, 22 Aug 2012, Lan Tianyu wrote: > >>>> At first time, the usb port devices have not been created and not bound >>>> with acpi. So at that time, port's DeviceRemovable is not set according >>>> acpi information. After ports' devices are created, binding procedure is >>>> completed. Request hub descriptor again and DeviceRemovable will be >>>> updated by acpi information. >>> >>> Why not just update the ACPI information using the current hub >>> descriptor? You don't need to fetch the hub descriptor again. >>> >> You mean to set DeviceRemovable directly rather than via hub descriptor request >> here, right? > > Right. DeviceRemovable should be set in only one place, and this > should be that place. > But if other places got hub descriptor, they can't get DeviceRemovable value since we only set DeviceRemovable in the hub_configure().(e.g lsusb). Another problem is that some hcds will set DeviceRemovable themselves. There will be a conflict between hcd and acpi information. Different hcds may have different processes. So at first, I put setting DeviceRemovable in the hcd's hub descriptor request routine. > Alan Stern > -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
