Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 22 Aug 2012, Lan Tianyu wrote:

> >> At first time, the usb port devices have not been created and not bound
> >> with acpi. So at that time, port's DeviceRemovable is not set according
> >> acpi information. After ports' devices are created, binding procedure is
> >> completed. Request hub descriptor again and DeviceRemovable will be
> >> updated by acpi information.
> >
> > Why not just update the ACPI information using the current hub
> > descriptor?  You don't need to fetch the hub descriptor again.
> >
> You mean to set DeviceRemovable directly rather than via hub descriptor request
> here, right?

Right.  DeviceRemovable should be set in only one place, and this
should be that place.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux