On 08/22/2012 05:28 PM, Alan Stern wrote:
Pardon me for being stupid, but I don't understand this description at all. Example one, on the first line: How is file_storage a direct user of the gadget driver? It _is_ the gadget driver!
I meant the fact that that file_storage is using struct usb_gadget_driver directly. In contrast to this most other do use composite as the glue layer.
Example two, on the fifth line: The patch passes the usb_gadget_driver structure as an argument to what function? There are lots of other examples. It's clear that the purpose of this patch is to change composite.c. The other source files just go along for the ride -- their bind routines get an additional, unused argument. Therefore the patch description should explain what part of composite.c is being changed and why the change is needed.
Okay. I will provide a better description.
Alan Stern
Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
