Re: [PATCH V7 2/9] usb: make usb port a real device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 08, 2012 at 09:28:35AM -0700, Greg KH wrote:
> On Sat, Jul 07, 2012 at 08:05:47PM -0400, Sarah Sharp wrote:
> > On Fri, Jul 06, 2012 at 11:12:32AM -0700, Greg KH wrote:
> > > On Fri, Jul 06, 2012 at 02:13:53PM +0800, Lan Tianyu wrote:
> > > Don't split strings across a line, it makes it impossible to search
> > > for.
> > 
> > Do you prefer 80 char lines or split strings?  checkpatch.pl throws an
> > error either way, so pick your poison.
> 
> checkpatch should not throw an error if you have a string which forces
> the line to be longer than 80 characters.  If it does, it is wrong and
> should be fixed.

It does.  I've tried to send checkpatch fixes in the past (including
making any warning not make the script return an error so you can have
it in your pre-commit hook) and gotten no response.  At this point I'm
not really sure who to send patches to.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux