On Sat, Jul 07, 2012 at 08:05:47PM -0400, Sarah Sharp wrote: > On Fri, Jul 06, 2012 at 11:12:32AM -0700, Greg KH wrote: > > On Fri, Jul 06, 2012 at 02:13:53PM +0800, Lan Tianyu wrote: > > > Change since v4: remove struct usb_port->udev member since it is not used. > > > > > > This patch is to make usb port a real device under usb hub interface. > > > Move port_owner to struct usb_port. > > > > As this adds sysfs files, this patch needs a Documentation/ABI update as > > well. > > So do I also need to update Documentation/ABI for the new ltm_capable > sysfs file? Oops, yes, I missed that, please do. > > Also, one minor nit: > > > > > + dev_err(hub->intfdev, "couldn't create port%d " > > > + "device.\n", i + 1); > > > > Don't split strings across a line, it makes it impossible to search > > for. > > Do you prefer 80 char lines or split strings? checkpatch.pl throws an > error either way, so pick your poison. checkpatch should not throw an error if you have a string which forces the line to be longer than 80 characters. If it does, it is wrong and should be fixed. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
