RE: [PATCH] usb: musb: davinci: Fix build breakage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sekhar Nori wrote:
> On 5/24/2012 5:23 PM, Sergei Shtylyov wrote:
>> On 24-05-2012 6:25, Jon Povey wrote:

>>> This follows from my email "DaVinci MUSB driver compile errors on
>>> 3.4" I suppose this should go to stable too, but I can't see a nice
>>> way to add them as CC in the patch but NOT email them right now
>>> when using git send-email.
>>
>>    You can do both at once AFAIK.
>
> I do this by including a --suppress-cc=cc and then Ccing the
> e-mail ids
> I actually need explicitly. May be there is a better way.
>
> This fix should only go into v3.4.x so please indicate that
> when copying
> stable.
>
> Cc: <stable@xxxxxxxxxxxxxxx> # v3.4.x

Happily my git send-email (1.6.3.3) turns out to have a feature/bug where
the trailing # stuff on that Cc makes it unable to extract that email
address - exactly what I want!

Maybe if stable guys don't want to be CC'd by email they should pick a
different tag for the commit message..

>>> To test on DM365 I had to apply a patch similar to this one:
>>>
> http://linux.omap.com/pipermail/davinci-linux-open-source/2011
> -July/023212.html
>>>
>>
>>    That patch wasn't split/recast as needed that's why it wasn't
>> accepted.

It would be nice if someone at TI were to pick this up, at the moment
there is no mainline support for DM365 USB, and if it is supposed to work
with some board support mods, it seems the musb driver side is now broken
and getting no testing.

>>> As a separate issue, MUSB drivers seem quite broken on DM365 in 3.2
>>> and 3.4, but at least with this patch they compile. One step at a
>>> time..
>>
>>    Maybe I'll try to test it on DM6446 EVM. Though it doesn'[t
>> support OTG mode...
>
> I beat Sergei to it! I tested this on DM6446 EVM using a mass storage
> device in PIO mode. After fixing issues above that Sergei mentioned,
> please add my:
>
> Acked-by: Sekhar Nori <nsekhar@xxxxxx>

Added and resent, thanks.

But maybe take a look on a DM365 EVM..? Pretty broken for me.

--
Jon Povey
jon.povey@xxxxxxxxxxxxxxx

Racelogic is a limited company registered in England. Registered number 2743719 .
Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB .

The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux