Hi Jon, On 5/24/2012 5:23 PM, Sergei Shtylyov wrote: > Hello. > > On 24-05-2012 6:25, Jon Povey wrote: > >> This appears to have been broken by >> commit 5cfb19ac604a68c030b245561f575c2d1bac1d49 > > Please also specify that commit's summary in parens. > >> For now, fix by hardcoding USB_PHY_CTRL and DM355_DEEPSLEEP > >> Tested on DM365 with defconfig changes. > >> Signed-off-by: Jon Povey<jon.povey@xxxxxxxxxxxxxxx> >> Cc: Sekhar Nori<nsekhar@xxxxxx> >> Cc: Felipe Balbi<balbi@xxxxxx> >> --- >> This follows from my email "DaVinci MUSB driver compile errors on 3.4" >> I suppose this should go to stable too, but I can't see a nice way to add >> them as CC in the patch but NOT email them right now when using git >> send-email. > > You can do both at once AFAIK. I do this by including a --suppress-cc=cc and then Ccing the e-mail ids I actually need explicitly. May be there is a better way. This fix should only go into v3.4.x so please indicate that when copying stable. Cc: <stable@xxxxxxxxxxxxxxx> # v3.4.x >> To test on DM365 I had to apply a patch similar to this one: >> http://linux.omap.com/pipermail/davinci-linux-open-source/2011-July/023212.html >> > > That patch wasn't split/recast as needed that's why it wasn't accepted. > >> As a separate issue, MUSB drivers seem quite broken on DM365 in 3.2 >> and 3.4, >> but at least with this patch they compile. One step at a time.. > > Maybe I'll try to test it on DM6446 EVM. Though it doesn'[t support > OTG mode... I beat Sergei to it! I tested this on DM6446 EVM using a mass storage device in PIO mode. After fixing issues above that Sergei mentioned, please add my: Acked-by: Sekhar Nori <nsekhar@xxxxxx> Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
