Hi Jon, On 5/23/2012 8:24 AM, Jon Povey wrote: > I've just been trying to build musb driver modules for DM365 on > kernel 3.4. I am getting errors which I think are due to the rearrangement > of the mach-davinci/davinci.h and associated headers: > > CC [M] drivers/usb/musb/davinci.o > drivers/usb/musb/davinci.c: In function 'phy_on': > drivers/usb/musb/davinci.c:67: error: implicit declaration of function 'IO_ADDRESS' > drivers/usb/musb/davinci.c:67: error: 'DAVINCI_SYSTEM_MODULE_BASE' undeclared (first use in this function) > > Not sure the right way to fix, I am just bodging for now. I see this too. Looks like this was missed all along because the davinci_all_defconfig does not enable the MUSB davinci glue layer. This needs to be corrected too. There is a lot of machine specific code in the davinci glue layer which needs to be cleaned up for a correct solution to this issue. For now, to fix this regression, we can directly define USB_PHY_CTRL and DM355_DEEPSLEEP to the correct register addresses. Then include <mach/hardware.h> to get definition of IO_ADDRESS(). I guess this what you did too. Do you mind sending this to Felipe and checking if he is OK with taking it? Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html