[PATCH 0/3] misc chipidea cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Here are three cleanups for the msm chipidea glue layer.

The whole msm chipidea USB support is still quite screwed
up. If you look at msm_otg.c, ehci-msm.c and ci13xxx_msm.c
you will notice that it constantly redefines MSM_USB_BASE
just so it can add to the register defines.

But the way read/write[bsl] functions are normally written is
by passing base and offset as arguments to those functions,
and do the addition operation inside the fucntion body.

This would mean, registers would be defined in terms of offsets
from the base only, but they would not add to base themselves.

That would help remove MSM_USB_BASE from all those files. Such
cleanup I'll leave as exercise for the authors of those drivers.

Felipe Balbi (3):
  usb: chipidea: drop useless arch-check
  usb: chipidea: msm: add missing section annotation
  usb: chipidea: msm: add remove method

 drivers/usb/chipidea/Makefile      |    8 +++++---
 drivers/usb/chipidea/ci13xxx_msm.c |   22 +++++++++++++++-------
 2 files changed, 20 insertions(+), 10 deletions(-)

-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux