Re: [RFC 06/13] USB: Add support to enable/disable USB3 link states.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 May 2012, Sarah Sharp wrote:

> On Fri, May 18, 2012 at 12:08:37PM -0400, Alan Stern wrote:
> > On Thu, 17 May 2012, Sarah Sharp wrote:
> > 
> > > > On an unrelated note, hub.c is already by far the largest source file 
> > > > in drivers/usb/core -- and you're adding another thousand lines or so.  
> > > > Maybe it's time to consider splitting it into two or more files.
> > > 
> > > I can look at splitting out the link PM code into a separate file, sure.
> > > But I have no idea how best to split up the rest of the hub.c code, and
> > > no real desire to do so as part of this particular patchset.
> > 
> > I didn't mean that it should be done right now, and certainly not as 
> > part of this patch set.  But it should get done in the not-too-distant 
> > future.
> 
> Ah, good. :)  Do you have any more comments on the revised patches?

I haven't had time to look at them at all closely.  At first glance 
they now seem okay.  (Except that you again forgot to update the 
kerneldoc for struct usb_device in patch 6/13, where lpm_disable_count 
was added.)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux