> > By the way, why not return directly when it sees a id change interrupt > > at ci_irq? > > Technically, OTGSC is independent from host or device mode, so I assume > there is a possibility of other device or host related interrupts > arriving at the same time. But your controller mode is still not changed as it will be done at work queue. So, it may some unexpected interrupt, even you have not handled, as the status is not cleared, it will come soon. > > I do call hw_device_reset(..., USBMODE_CM_DC) in udc_start *unless* the > SHARED flag is set by the platform (currently, msm does that). The > SHARED flag basically means that we have other driver(s) taking care of > some of the functionality, like controller reset. In case of msm it's > done by msm_otg.c. If we expand ci_hdrc to handle otg properly, there > won't be a need for that (and the separate otg and ehci drivers). > Oh, yes, hw_device_reset is here. It is my careless. So, it is better only switch device driver to chipidea now, for otg and host, it is somehow incomplete at current chipidea architecture. Do you think so? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
