> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Alexander Shishkin > Sent: Friday, May 11, 2012 8:06 AM > To: Greg Kroah-Hartman > Cc: linux-usb@xxxxxxxxxxxxxxx; Felipe Balbi; Alexander Shishkin; Alan > Stern > Subject: [PATCH v8 15/20] usb: chipidea: add host role > > This adds EHCI host support to the chipidea driver. We want it to be > part of the hdrc driver and not a standalone (sub-)driver module, as > the structure of ehci-hcd.c suggests, so for chipidea controller we > hack it to not provide platform-related code, but only the ehci hcd. > > The ehci-platform driver won't work for us here too, because the > controller uses the same registers for both device and host mode and > also otg-related bits, so it's not really possible to put ehci registers > into a separate resource. > > This is not a pretty solution, but the alternative is exporting symbols > from the chipidea driver to a ehci-chipidea driver and doing all the > module refcounting. > Hi Alexander, First, it is really great work, and I hope we can all switch to it in future. I can't find summery for this patchset, so I have added some of my questions here, some of them I asked yesterday, but does not get answers. Some of Freescale i.MX users would like to use your structure, so I go through your code, and would like to know your comments for below questions: - How to support OTG, you will give up struct usb_otg or not? - When ID switch occurs, do udc_start/udc_stop is enough, seems no registers operation? - I have not found vbus interrupt code which is used to stand for connect and disconnect at device mode. - Seems hcd will register interrupt 0 irq handler, if the system has really interrupt 0 irq handler, it may mess up. - Current, there is no PHY Layer code (I will begin to do it soon), so your PHY operation is at udc code, once the PHY Layer code is ready, do you will move it to core.c? - What's your plan for low power mode and wakeup support? - For host driver, what's plan to add controller callback (override struct hc_driver) for vendor special, like you have done for udc. Seems you have moved msm udc to chipidea folder, but have not changed host and otg part, how msm user goes on using usb driver? Best Regards, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
