Hi Afzal,
On 05/03/2012 03:37 AM, Mohammed, Afzal wrote:
> Hi Jon,
>
> On Wed, May 02, 2012 at 02:11:48, Hunter, Jon wrote:
>>> +
>>> + pdata->clk_prd = gpmc_get_fclk_period();
>>
>> Does this need to be done here? May be this should be done in the probe
>> function. You could store the handle to the main clk in the pdata.
>
> This is done so that migration of gpmc driver to the drivers folder
> would be smooth, remember that this function will still live here.
Sure, but why call this here?
>>> + pr_err("error: clk_get on %s\n", oh->main_clk);
>>> + return -EINVAL;
>>> }
>>>
>>> clk_enable(gpmc_l3_clk);
>>
>> I would have thought we should be able to remove the gpmc_init function
>> completely by now. Most of the code should be moved to the probe function.
>>
>> Also now with hwmod in place, we should be able to remove the
>> clk_enable/disable functions and use the pm_runtime APIs instead.
>
> There was no plan to add rpm in this series, but now that you have
> brought it up, I will adapt the driver to rpm.
Ok, great.
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
