Hi Jon, On Fri, May 04, 2012 at 22:00:21, Hunter, Jon wrote: > >>> + > >>> + pdata->clk_prd = gpmc_get_fclk_period(); > >> > >> Does this need to be done here? May be this should be done in the probe > >> function. You could store the handle to the main clk in the pdata. > > > > This is done so that migration of gpmc driver to the drivers folder > > would be smooth, remember that this function will still live here. > > Sure, but why call this here? Clk_prd is a platform data passed to the driver, so platform code updates it, where else can it be done ? Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
