> -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] > Sent: Tuesday, May 01, 2012 3:09 PM > To: Haiyang Zhang > Cc: netdev@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Greg Kroah-Hartman; > David S. Miller; Felipe Balbi; Jussi Kivilinna; Wei Yongjun; Ben Hutchings > Subject: Re: [PATCH 02/13 v4] usb/net: rndis: break out <linux/rndis.h> > defines > > On Tue, May 1, 2012 at 8:54 PM, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > wrote: > > >> ChangeLog v2->v3: > >> - Squashed subsequent patch removing duplicate entries into > >> this patch so it's bisectable without any compilation warnings. > > > > I have not reviewed this version yet. > > > > Also, I think you should merge the "ChangeLog v2->v3" into the patch > > comments. Don't need to say "The compilation screams about double- > defines > > all over the place" any more. > > This one is completely bogus, please review the v4 versions of the > patches instead. I was halfway on this one and screwed it up > somehow, I've had better days :-( Yes, I'm replying to your v4 patch. It contains the "ChangeLog v2->v3", and still says "The compilation screams about double-defines all over the place" in the comments. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
