> -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] > Sent: Tuesday, May 01, 2012 2:22 PM > To: netdev@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Greg Kroah-Hartman; > David S. Miller; Felipe Balbi > Cc: Jussi Kivilinna; Haiyang Zhang; Wei Yongjun; Ben Hutchings; Linus > Walleij > Subject: [PATCH 02/13 v4] usb/net: rndis: break out <linux/rndis.h> > defines > > As a first step to consolidate the RNDIS implementations, break out > a common file with all the #defines and move it to <linux/rndis.h>. > The compilation screams about double-defines all over the place > (as could be expected, this is why we're consolidating) but it > compiles cleanly still. > > This also deletes the immediate duplicated defines in the > <linux/rndis.h> file that yields a lot of compilation warnings. > > Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v2->v3: > - Squashed subsequent patch removing duplicate entries into > this patch so it's bisectable without any compilation warnings. I have not reviewed this version yet. Also, I think you should merge the "ChangeLog v2->v3" into the patch comments. Don't need to say "The compilation screams about double-defines all over the place" any more. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html