On Tue, May 01, 2012 at 10:51:45AM -0400, Christopher Harvey wrote: > On Mon, Apr 30, 2012 at 03:51:06PM -0400, Christopher Harvey wrote: > > On Mon, Apr 30, 2012 at 03:17:33PM -0400, Alan Stern wrote: > > > On Mon, 30 Apr 2012, Sarah Sharp wrote: > > > > > > > On Fri, Apr 27, 2012 at 03:30:24PM -0400, Christopher Harvey wrote: > > > > > I have a Lenovo U300s and I was about to look into this over the > > > > > weekend. Looking forward to testing any patches or providing hardware > > > > > info. Feel free to CC me on anything related to this bug. > > > > > > > > Great! Do you think you could compile a custom kernel, and test whether > > > > your suspend issues are solved? I've pushed a custom kernel that > > > > extends Alan's patch to your Lenovo EHCI host controllers: > > > > > > > > git clone -b for-usb-linus-lenovo-fix git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git > > > > > > > > If that still doesn't work, I'll spin a patch that adds the quirk to the > > > > xHCI host as well. > > > > > > > > We might need to add the Lenovo subsystem product ID as well to this > > > > quirk. I have a Lenovo x220 with two EHCI and one xHCI host controller, > > > > with a subsystem vendor:device ID of 17aa:21da. Suspend seems to work > > > > fine on this system, although it's never been able to hibernate > > > > properly, and I haven't had time to look into it. > > > > > > FYI, another patch has been submitted which appears to solve the > > > underlying problem rather than simply blacklisting certain controllers: > > > > > > http://marc.info/?l=linux-pm&m=133573212512122&w=2 > > > > > > You might want to test that patch instead of the one I wrote. > > > > > > Alan Stern > > > > I'll take a look at both of these tonight and report any news tomorrow. > > The ehci patch did the trick for me. I didn't get a chance to test the > PM one, but somebody else on this mailing list did. Thanks for testing! However, I think the PM one should go in instead of my EHCI quirk patch. Alan, will the ASUS EHCI patch get reverted now that we know the real cause was some missing ACPI calls? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html