On Sun, Mar 18, 2012 at 01:25:30PM +0400, tamerlan311 wrote:
> 2012/3/18 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> On Sat, Mar 17, 2012 at 08:07:07PM +0400, Aleksey Babahin wrote:
> > Without this declaration we can`t use interrupt_out_endpointAddress.
> > ---
> > drivers/usb/serial/metro-usb.c | 9 +++++++++
> > 1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/
> metro-usb.c
> > index 08d16e8..6dba779 100644
> > --- a/drivers/usb/serial/metro-usb.c
> > +++ b/drivers/usb/serial/metro-usb.c
> > @@ -136,6 +136,14 @@ exit:
> > __func__, result);
> > }
> >
> > +static void metrousb_write_int_callback (struct urb *urb)
> > +{
> > + struct usb_serial_port *port = urb->context;
> > +
> > + dev_warn(&port->dev, "%s not implemented yet.\n"
> > + ,__FUNCTION__);
> > +}
>
> So you enable it, and then complain to the user that it's broken? That
> doesn't make sense...
>
>
> This function is never called at now. Because we don`t send much data to
> device.
>
> Only one byte is sent to device via usb_interrupt_msg(), which does not require
> callback function.
> But without declaration of .write_int_callback in usb_serial_driver struct, the
> usb_serial_core subsystem doesn`t initialize endpoint address for the interrupt
> out pipe (interrupt_out_endpointAddress). This endpoint is necessary for
> sending data via usb_interrupt_msg() function and i don`t know other way to get
> it.
Ah, ok, then explain this in the patch submission please, that is a
reason to accept this.
Care to redo this series and resend it so I can apply them?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
