Re: [PATCH 2/4] USB: serial: metro-usb: dummy implement write_int_callback function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 17-03-2012 16:17, Aleksey Babahin wrote:

Without this declaration we can`t use interrupt_out_endpointAddress.
---
  drivers/usb/serial/metro-usb.c |    9 +++++++++
  1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index 08d16e8..6dba779 100644
--- a/drivers/usb/serial/metro-usb.c
+++ b/drivers/usb/serial/metro-usb.c
@@ -136,6 +136,14 @@ exit:
  			__func__, result);
  }

+static void metrousb_write_int_callback (struct urb *urb)

Have you run the patch thru scripts/checkpatch.pl? It should have warned you about space before paren...

+{
+	struct usb_serial_port *port = urb->context;
+
+	dev_warn(&port->dev, "%s not implemented yet.\n"
+		,__FUNCTION__);

Strange way ti deal with comma on breaking the line. You also shouldn't use __FUNCTION__ but __func__ instead.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux