Hi, > BTW, you should write your patch on top of the two patches I sent adding > support for xhci on dwc3. It's on the archives of the mailing and this > is the second time I suggest you do that. > OK, I see, sorry about that. So I guess it should be part of xhci_plat_probe() ? >> I mean, the "set_host" API is a generic one defined in otg.h as part of >> the general otg framework, no pltaform specific. >> Actually it will serve any otg driver, on any core that supports xHCI >> interface, not just for the dwc3 core. >> How do you suggest to do this otherwise? > > like I said on the other mail. ->set_host() needs to be called way > before that. When you get ID pin grounded, if your controller doesn't go > into host mode automagically, you call ->set_host(). You should have > some sort of ID ground event to handle that. > Sorry, I missed you here. Isn't the otg_set_host() should be called just after hcd instance was created (in xhci_plat_prob?) for notifying the otg about the instance of the host driver? Why it is related to ID ground event? maybe you talked about ->start_host() ? And one more question, please: If indeed the place to call otg_set_host is in xhci_plat_probe(), then if otg instance exists (otg_get_transceiver()!=NULL) then the otg_set_host() should be called instead of the 2 calls to usb_add_hcd(), right ? If so, do need to call otg_set_host with the primary hcd? , but when the otg->start_host is activated then call to usb_add_hcd() twice on both the primary and the secondary (using the shared_hcd reference) ? > -- > balbi > Many thanks for your help, Ido -- Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
