Hi,
On Tue, Feb 14, 2012 at 07:28:51AM -0800, Ido Shayevitz wrote:
> I am adding an otg driver for dwc3 core (hope that I will release it for
> RFC soon) and I have some questions about the xHCI driver, since I guess I
> need to do some changes in the xHCI to regirtser itself to the otg.
xHCI should not register itself to the OTG, I think you're taking the
wrong approach. See the latest patch I sent creating the xHCI device for
use by the xhci-plat.c file.
> First, I understand that there is secondary and primary hcd ? can you give
> me more insight on this ?
every USB3 roothub is composed of a SuperSpeed hub and a HS/FS/LS hub.
> Second, I see that in the xHCI-pci-probe the usb_add_hcd is called on the
> secondary (right?) while the irq are set only if the hcd is primary (so
> how it works?)
>
> Do I need to change in the xhci-pci-probe to be something like this:
>
> otg = usb_get_transceiver();
> if (otg) {
> retval = otg_set_host(otg, hcd_to_bus(xhci->shared_hcd));
> }
this should not be added to xhci driver, not at all. You need to change
this mode waaaaay before when ID pin is grounded.
I really wouldn't like seeing this kind of code added to the core xHCI
driver and I think Sarah wouldn't like it either.
--
balbi
Attachment:
signature.asc
Description: Digital signature
