On Thu, Feb 16, 2012 at 9:41 AM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote: > When build i.mx platform with imx_v6_v7_defconfig, and after adding > USB Gadget support, it has below build error: > > CC drivers/usb/host/fsl-mph-dr-of.o > drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register': > drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' > has no member named 'dma_mask' > > It has discussed at: http://www.spinics.net/lists/linux-usb/msg57302.html > > For PowerPC, there is dma_mask at struct pdev_archdata, but there is > no dma_mask at struct pdev_archdata for ARM. The pdev_archdata is > related to specific platform, it should NOT be accessed by > cross platform drivers, like USB. > > The code for pdev_archdata should be useless, as for PowerPC, > it has already gotten the value for pdev->dev.dma_mask at function > arch_setup_pdev_archdata of arch/powerpc/kernel/setup-common.c. > > Tested-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > --- > drivers/usb/host/fsl-mph-dr-of.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c > index 7916e56..ab333ac 100644 > --- a/drivers/usb/host/fsl-mph-dr-of.c > +++ b/drivers/usb/host/fsl-mph-dr-of.c > @@ -94,7 +94,6 @@ struct platform_device * __devinit fsl_usb2_device_register( > pdev->dev.parent = &ofdev->dev; > > pdev->dev.coherent_dma_mask = ofdev->dev.coherent_dma_mask; > - pdev->dev.dma_mask = &pdev->archdata.dma_mask; > *pdev->dev.dma_mask = *ofdev->dev.dma_mask; > > retval = platform_device_add_data(pdev, pdata, sizeof(*pdata)); Hi Leo, can your guys give me an ACK for it? Then, Alan can apply it. Ramneek has already tested it, and confirmed it did not break host function at his platform. > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- BR, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
