2012/2/18 Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>: > Hi Elric, > > Thanks for sending this patch. It has a couple issues, and I hope > you'll find the time to fix them up. :) > > First, I would suggest you run your patch through scripts/checkpatch.pl. > You can do that with a command like this: > > git diff HEAD^ | perl scripts/checkpatch.pl --no-signoff - > > That script will make sure you are matching the kernel coding style. > > The script is mostly complaining that you used spaces instead of tabs to > indent your code. You probably need to make sure that your editor is > using hard tab stops, instead of inserting spaces when you press tab. > > There's also some trailing whitespace at the end of lines. I used to do > that all the time, until I discovered the magic .vimrc lines to > highlight trailing whitespace. Unfortunately, those lines don't work on > c files for newer vim versions anymore (but it works for .txt files, go > figure). In any case, seeing trailing white spaces in bright red seemed > to have trained me out of leaving them in the code, so maybe you can > figure out how to get your editor to highlight trailing white spaces. :) > > Please fix any errors or warnings from checkpatch.pl and resubmit your patch. > > Also, can you pick a shorter short description for your patch? > Descriptions shorter than 50 characters usually display well with our > tools, and don't cause mail client subject line wrap. > > How about instead of > > "fix bug of device attached to superspeed hub can't be re-enumerated after resume" > > say > > "USB: Set USB3 hub depth after device reset"? > > We like to have the subsystem for the patch, although I sometimes have > to add it later. > > Kudos for sending a patch that actually applies correctly, following the > SubmittingPatches documentation, and figuring out which stable kernel > this should apply to. :) You just need to fix up a few things and > resubmit. I'm really sorry for the inconvenience. I'll fix up those issues to ensure that the patch meets all requirements and resubmit it. Thank you for reminding me. Best Regards, Elric Fu -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
