-----Original Message----- From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Mehresh Ramneek-B31383 Sent: Thursday, February 16, 2012 3:44 PM To: Chen Peter-B29397 Cc: linux-usb@xxxxxxxxxxxxxxx; Li Yang-R58472; Aggrwal Poonam-B10812 Subject: RE: [PATCH][v4]fsl/usb:Add controller version based ULPI and UTMI phy support > -----Original Message----- > From: Chen Peter-B29397 > Sent: Thursday, February 16, 2012 3:18 PM > To: Mehresh Ramneek-B31383 > Cc: linux-usb@xxxxxxxxxxxxxxx; Li Yang-R58472 > Subject: RE: [PATCH][v4]fsl/usb:Add controller version based ULPI and > UTMI phy support > > > > I see 2 issues here: > > > > 1. Device-tree not being used for IMX platforms > > 2. sysif_regs not defined for IMX platforms > > > > For the first issue, I can replace CONFIG_ARCH_MXC macro with > > usb_get_ver_info() > > returning some standard error value for nonDT platforms > > > > For the second issue, we can replace CONFIG_ARCH_MXC macro with > > if (pdata->have_sysif_regs) for IMX platforms > > > > Is it possible to define pdata->have_sysif_regs = 0 for IMX > > platforms ?? > > > Just how much effort it'll be for IMX team to define this for their platforms ? We should try and resolve this issue together. I'm providing my support in every possible way, even offering to alter functions to return values for imx platforms. You cannot keep asking people to send patches for the platforms that imx team is supposed to maintain...we need to work together to resolve issues... I'm trying to clean up fsl usb gadget code here, and this patch is the first step towards it. We can keep working to get rid of other soc macros also in subsequent patches... --Ramneek > Please grep the source, you will find the i.mx does not define > have_sysif_regs > > Regards, > > Ramneek > > > > > > > Instead of using CONFIG_ARCH_MXC macro, usb_get_ver_info() can > > > > be > > used > > > > to shield this code for IMX based platforms...as discussed > previously, > > > > this function returns 0 for IMX platforms... > > > > > > > Your code is ok, the problem is your code uses the structure which > > > is > > not > > > defined at i.mx platform. > > > > > > > Regards, > > > > Ramneek > > > > Hi Peter/ Leo I reckon using CONFIG_USB_FSL_MPH_DR_OF to exclude the code inside gadget driver for nonDT platforms like imx can resolve this issue... Please suggest... Regards, Ramneek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
