On Mon, Feb 13, 2012 at 01:38:58PM +0200, Felipe Balbi wrote: > On Mon, Feb 13, 2012 at 01:24:19PM +0200, Heikki Krogerus wrote: > > All the drivers are now converted to use struct usb_otg, so > > removing the OTG specific members from struct usb_phy. > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > Reviewed-by: Marek Vasut <marek.vasut@xxxxxxxxx> > > breaks compilation: > > drivers/usb/musb/musb_gadget.c: In function ‘musb_gadget_enable’: > drivers/usb/musb/musb_gadget.c:1085:3: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] > drivers/usb/musb/musb_gadget.c:1125:3: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] > drivers/usb/musb/musb_gadget.c: In function ‘musb_gadget_start’: > drivers/usb/musb/musb_gadget.c:1948:20: error: ‘struct usb_phy’ has no member named ‘set_vbus’ > make[2]: *** [drivers/usb/musb/musb_gadget.o] Error 1 > make[1]: *** [drivers/usb/musb] Error 2 > make: *** [drivers/usb/] Error 2 > > I will fix it this time, but next time I will silently drop your series. > MUSB is even compilable on x86. I did not test bisectability with MUSB with every version of this set, I'm sorry about that. I only tested if musb compiles after 14/19 and 19/19 of this set, which was really wrong of me. I change the set_vbus in 19/19 of this set while I should have fixed it already in 14/19. This made the musb compile with the whole set, making me thing it's OK. I'm sorry about this and I promise to be more careful next time. I'll send fixed versions of 14/19 and 19/19 if it's OK. -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
