Re: [PATCH 1/2] usb: renesas_usbhs: (cosmetic) simplify list operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 13, 2012 at 01:19:36PM +0100, Guennadi Liakhovetski wrote:
> On Mon, 13 Feb 2012, Felipe Balbi wrote:
> 
> > On Thu, Feb 09, 2012 at 11:17:47PM +0100, Guennadi Liakhovetski wrote:
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > 
> > if (patch_has_no_commit_log(path)) {
> > 	kfree(patch);
> > 	continue;
> > }
> 
> It is a common practice to omit a commit log in trivial patches, where the 
> subject says it all, just look through git log. IMHO this is one of those 
> cases - what else can you add to the statement in subj?

something like:

"list.h already provide helpers to find the first entry and to move the
tail of one list to another list. This patch simply uses those helpers,
no functional changes".

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux